Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: The locator makes it possible to have point geometry even when this is not an allowed type #2

Closed
jbostoen opened this issue Oct 22, 2023 · 2 comments
Closed

Bug: The locator makes it possible to have point geometry even when this is not an allowed type #2

jbostoen opened this issue Oct 22, 2023 · 2 comments
Assignees
@jbostoen
Labels
bug Something isn't working

Comments

@jbostoen
Copy link
Owner

jbostoen commented Oct 22, 2023 •
edited

When editing an object and using the locator, by default it creates or updates the existing feature to a point feature with the discovered coordinates.

The locator tool should:

  • If a different type is returned in OSM (for example a line or polygon): Center to the point.
  • Else: Just center.

Only when editing: the feature will be created or updated only if it matches the currently selected feature type.
@jbostoen jbostoen added the bug Something isn't working label Oct 22, 2023
@jbostoen jbostoen self-assigned this Oct 22, 2023
@jbostoen
Copy link
Owner Author

This requires https://github.com/jbostoen/itop-jb-map/issues/26

@jbostoen
Copy link
Owner Author

Some locations to test:

  • Manneken Pis (= point)
  • Ghelamco Arena Ghent ( = polygon with hole)

jbostoen added a commit that referenced this issue Oct 23, 2023
@jbostoen
* Fix: Bug: The locator makes it possible to have point geometry even…
59c8651 
… when this is not an allowed type (#2)
jbostoen added a commit that referenced this issue Oct 23, 2023
@jbostoen
* Fix: Bug: The locator makes it possible to have point geometry even…
ff4381d 
… when this is not an allowed type (#2)

* Show locator in dashlets as well (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbostoen jbostoen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbostoen