Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous offset/start behavior #264

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Fix erroneous offset/start behavior #264

merged 1 commit into from
Feb 17, 2018

Commits on Nov 23, 2017

  1. Fix database offset queries to use the actual "start" parameter value. 

    If the start value wasn't an exact multiple of the limit, then
previously the database query would not acknowledge intermediate offset
values. So, for example, if a request with start=20&limit=100 was made,
ajax-datatables-rails would perform a "LIMIT 100 OFFSET 0" query,
instead of "LIMIT 100 OFFSET 20" (which is what is intended).
    @GUI
    GUI committed Nov 23, 2017
    Configuration menu
    Copy the full SHA
    5fe09e9 View commit details
    Browse the repository at this point in the history