Skip to content

Commit

Permalink
Fix gofmt issue (openshift#1192)
Browse files Browse the repository at this point in the history
When running "make verify" I see this:
```
Running gofmt:
Running golint and go vet:
pkg/apis/servicecatalog/checksum/checksum_test.go
```

What's odd is that the file name is due to the gofmt not the golint.
But, the real issues are:
1) the `&>` in the Makefile isn't getting picked up
2) the gofmt issue

This PR replaces `&>` with `> .out 2>&1`.
I don't need to fix that file any more because its been removed.

Signed-off-by: Doug Davis <dug@us.ibm.com>
  • Loading branch information
Doug Davis authored and pmorie committed Sep 6, 2017
1 parent 2ee894a commit 154b74d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ $(BINDIR)/e2e.test: .init
.PHONY: verify verify-client-gen
verify: .init .generate_files verify-client-gen
@echo Running gofmt:
@$(DOCKER_CMD) gofmt -l -s $(TOP_TEST_DIRS) $(TOP_SRC_DIRS) &> .out || true
@$(DOCKER_CMD) gofmt -l -s $(TOP_TEST_DIRS) $(TOP_SRC_DIRS)>.out 2>&1||true
@bash -c '[ "`cat .out`" == "" ] || \
(echo -e "\n*** Please 'gofmt' the following:" ; cat .out ; echo ; false)'
@rm .out
Expand Down

0 comments on commit 154b74d

Please sign in to comment.