Fix nan values in nominal x/y coordinates #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking through the issues, I think that we might want to apply some filling algo (e.g. #71) to solve this. Ill try to implement that next. |
|
I ultimately decided to not implement a full filling of the lon/lat coordinates at this point (I will post details in #71). Instead I have switched the way the nominal latitudes are defined (zonal max of the 2d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I have identified the problem for #66, which is that missing values in
lonare removed and then seem to produce nans in the dimension coordinates, which trips up xarray.Not exactly sure if I should compute the lons as the average/median along y? That would however change the values...
If #75 is not successful, we might consider removing this step all together instead.