Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Crash on file reading after initial use #22

Closed
jbwong05 opened this issue Oct 18, 2021 · 7 comments · Fixed by #25
Closed

[BUG] Crash on file reading after initial use #22

jbwong05 opened this issue Oct 18, 2021 · 7 comments · Fixed by #25
Labels
bug Something isn't working

Comments

@jbwong05
Copy link
Owner

Describe the bug
Crash on file reading after initial use

Desktop (please complete the following information):

  • OS Version: Windows 10 pro 19042.1237
  • OBS version 27.1.3
  • GDI+ Text Slide Show

Additional context
Mirror of reported issue from MMTech1 on the OBS discussion forum here

crash-2021-10-16-11-04-20.txt
@jbwong05 jbwong05 added the bug Something isn't working label Oct 18, 2021
@TackTick
Copy link

Encountered the same bug today: crash (unable to restart OBS unless the plugin is uninstalled).

Laptop:

  • OS Windows version: 10.0 build 19043
  • OBS 27.1.3
  • GDI+ Text Slide Show

211029 obs-text-slideshow crash.txt

@TackTick
Copy link

After some additional testing: the crash seems to be triggered when reading from a file containing two or more subsequent empty lines. In my case this is consistently reproducible.

Expected and preferred behavior for two or three emptly lines: an empty slide.

@jbwong05
Copy link
Owner Author

Thanks for the testing and the insight. Can you attach a copy of the text file that you have found is able to consistently crash the plugin?

@TackTick
Copy link

Here you go:

OTSS Normal.txt
OTSS Error.txt

Tested with identical file names.

@jbwong05
Copy link
Owner Author

Thanks for providing the files. Looks like the crash is reproducible on my end which is good. I will look into debugging and pushing a fix for it when I get the chance

@TackTick
Copy link

TackTick commented Oct 30, 2021 •
edited
Loading

That's great to hear.
And maybe there is a possibility to add the feature that multiple empty lines result in an empty slide. Of course only if that would be easily implementable. Thanks in any case!

jbwong05 added a commit that referenced this issue Oct 31, 2021
@jbwong05
Fixed multiline file crash on linux #22
42b50e1 
Multiline file reading crash has been fixed on linux but still needs to
be tested on Windows and Macos. Further examination of the file reading
logic can also be done to allow for certain blank lines to be read as a
blank slide
jbwong05 added a commit that referenced this issue Nov 10, 2021
@jbwong05
Extra new lines as blank lines or slides #22
11a8066 
Extra new line characters are now appended to the next slide or are
treated as blank slides if surrounded by new line characters
jbwong05 added a commit that referenced this issue Nov 10, 2021
@jbwong05
Fixed win64 compiler type warning #22
ad735f4
@jbwong05
Copy link
Owner Author

Fixes for the mentioned bugs have been tested on Linux and pushed to the dev branch. Need to conduct testing on Windows and MacOs before merging to master and releasing a new version

@jbwong05 jbwong05 mentioned this issue Nov 26, 2021
Merged
@jbwong05 jbwong05 linked a pull request Nov 26, 2021 that will close this issue
v1.5.2 #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.5.2 jbwong05/obs-text-slideshow
2 participants
@jbwong05 @TackTick