Issue #56

[tmjee]

• fixed issue NotNull annotations are inconsistently used #56
• integration test failed due to @NotNull constraint added see Integration tests fail @NotNull constraints #60

[dmarkov]

@tmjee Thanks, I will find someone to review this PR soon

[dmarkov]

@dmzaytsev it's yours, please review

[dmzaytsev]

@tmjee AttributeUpdates cannot be null, right?

[dmzaytsev]

@tmjee a few minor comments above

[dmzaytsev]

@tmjee todo task will be created automatically

fixed issue #56
integration test failed due to @NotNull constraint added see #60

[tmjee]

@dmzaytsev done

[dmzaytsev]

@tmjee thanks

[dmzaytsev]

@rultor merge

[rultor]

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@tmjee you're suppressing so many PMD checks... it's a bad idea. Wouldn't it better to make these string literals slightly different and that's it?

[tmjee]

@yegor256 done

[yegor256]

@tmjee I still see this: @SuppressWarnings("PMD.AvoidDuplicateLiterals"). Let's make sure all texts are unique

[tmjee]

@yegor256 done

[yegor256]

@rultor try to merge

[rultor]

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 6min)

[dmarkov]

@dmzaytsev paid, thanks, added 19 mins to your account, payment 66929873, 73 hours and 5 mins was spent; you're getting extra minutes here (c=4); added +19 to your rating, now it is equal to +1354

[dmarkov]

@rultor please deploy

[rultor]

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 5min)