Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#54 Adding PrintableConsumedCapacity class #82

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Conversation

prondzyn
Copy link
Contributor

@prondzyn prondzyn commented Sep 9, 2016

This is for #54

AwsTable#print is replaced by PrintableConsumedCapacity

@dmarkov
Copy link

dmarkov commented Sep 12, 2016

@prondzyn I will find a reviewer for your pull requests shortly, thanks for contribution!

@dmarkov
Copy link

dmarkov commented Sep 12, 2016

@original-brownbear it's yours, please review

@original-brownbear
Copy link

@prondzyn on it :)

@original-brownbear
Copy link

@prondzyn bit overkill from my perspective to do it this way :) but the issue asks for it and you did it properly imo :)

@original-brownbear
Copy link

@rultor merge pls

@rultor
Copy link
Contributor

rultor commented Sep 12, 2016

@rultor merge pls

@original-brownbear Thanks for your request. @yegor256 Please confirm this.

@prondzyn
Copy link
Contributor Author

@yegor256 ping

1 similar comment
@prondzyn
Copy link
Contributor Author

@yegor256 ping

@prondzyn
Copy link
Contributor Author

@yegor256 please confirm

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 23, 2016

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6cfe329 into jcabi:master Sep 23, 2016
@rultor
Copy link
Contributor

rultor commented Sep 23, 2016

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

@prondzyn prondzyn deleted the 54 branch September 23, 2016 20:26
@dmarkov
Copy link

dmarkov commented Sep 27, 2016

@original-brownbear Many thanks! 18 mins were added to your account in Transaction ID AP-3XN88515R40386923 (task took 336 hours and 24 mins). review comments (c=3) added as a bonus. +18 added to your rating, current score is: +8900

@dmarkov
Copy link

dmarkov commented Sep 27, 2016

@rultor deploy pls

@rultor
Copy link
Contributor

rultor commented Sep 27, 2016

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Sep 27, 2016

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 6min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants