Refactor com.jcabi.email.postman.PostNoLoops

[amihaiemil]

Currently the method

private boolean intersect(final Address[] first, final Address[] second, final String msg)

Is really huge and bluntly implemented.
It can be refactored to contain only a couple lines using Collections.retainAll().

I tried it and the tests passed fine.

    private boolean intersect(final Address[] first, final Address[] second,
        final String msg) {
        Collection<Address> firstCollection = new ArrayList<Address>(Arrays.asList(first));
        firstCollection.retainAll(Arrays.asList(second));
        boolean intersects = !firstCollection.isEmpty();
        if(intersects) {
            Logger.info(
                this,
                "Address(es) %s exist in both %s",
                firstCollection.toString(),msg
            );
        }
        return intersects;
    }

[dmarkov]

@yegor256 take a look at this issue please and dispatch it somehow, see par.21

[amihaiemil]

@yegor256 Can you have a look here pls? Thanks.

[dmarkov]

@amihaiemil thanks for tis bug, I topped your account for 15 mins, transaction AP-61L70367K0547154P

[dmarkov]

@prondzyn this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here

Task's budget is 30 mins (see this for explanation)

[prondzyn]

@dmarkov PR #49 prepared.

[dmarkov]

@dmarkov PR #49 prepared.

@prondzyn thanks for that

[prondzyn]

@amihaiemil please close the issue

[amihaiemil]

Sure thanks :)

[prondzyn]

@dmarkov the task is done

[dmarkov]

@dmarkov the task is done

@prondzyn thank you!

[dmarkov]

@prondzyn Thank you, I have added 30 mins to your account in payment/transaction "AP-0TA95484RH258244L", time consumed: 120 hours and 49 mins; added +30 to your rating, now it is equal to +60