Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StHeader #9

Closed
yegor256 opened this issue Jan 8, 2015 · 11 comments
Closed

StHeader #9

yegor256 opened this issue Jan 8, 2015 · 11 comments

Comments

@yegor256
Copy link
Member

yegor256 commented Jan 8, 2015

Let's create a new class StHeader, which will add a header to the email message.

@dmarkov
Copy link

dmarkov commented Jan 12, 2015

I'm aware of the task, give me some time to find a developer...

@dmarkov
Copy link

dmarkov commented Jan 12, 2015

@pinaf please pick this up, and keep in mind these instructions. Any technical questions - ask right here

Task's budget is 30 mins (see this for explanation)

@pinaf
Copy link
Contributor

pinaf commented Jan 12, 2015

@dmarkov thanks. Should I add a unit test also?

@yegor256
Copy link
Member Author

@pinaf of course, we always start with a test

@pinaf
Copy link
Contributor

pinaf commented Jan 12, 2015

alright. And is there any way I can run the code quality stuff to check everything before issuing the pull request? Or is the only way to let rultor do it when you guys attempt to merge?

@yegor256
Copy link
Member Author

@pinaf before you submit a pull request, run mvn clean install -Pqulice. that's what Travis and Rultor are doing to check the quality of the code

@pinaf
Copy link
Contributor

pinaf commented Jan 12, 2015

@yegor256 cool. had to upgrade maven because of this. sent pull request.

@pinaf
Copy link
Contributor

pinaf commented Jan 12, 2015

@dmarkov pull request #17

@pinaf
Copy link
Contributor

pinaf commented Jan 14, 2015

@yegor256 @dmarkov merged, please close.

@yegor256
Copy link
Member Author

@pinaf thanks!

@dmarkov
Copy link

dmarkov commented Jan 16, 2015

@pinaf Many thanks! 30 mins were added to your account in Transaction ID AP-34C10411UK2479534

+30 to your rating, your total score is +30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants