issue #9: new class StHeader, which will add a header to the email messa... #17
Conversation
|
Many thanks for the PR, let me find a reviewer for it |
|
@carlosmiranda please review, thanks |
| * @param hvalue Value to add under header's name | ||
| * @since 1.1 | ||
| */ | ||
| public StHeader(final String hname, final String hvalue) { |
There was a problem hiding this comment.
Let's call these params something else, like nme and val. See http://www.yegor256.com/2014/04/27/typical-mistakes-in-java-code.html#variable-names
|
@pinaf Just one comment above |
|
@carlosmiranda Thx. Initially I wanted name and value but qulice complained about shadowing. Should be good now. |
|
@pinaf Thanks for the update, we should be good now. |
|
@rultor Requesting a merge |
@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here |
@carlosmiranda Done! FYI, the full log is here (took me 8min) |
|
@carlosmiranda Thanks a lot, I just topped your account for 16 mins, transaction ID |
|
@rultor please deploy |
...ge