Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 8 #13

Merged
merged 19 commits into from
Jan 13, 2015
Merged

Task 8 #13

merged 19 commits into from
Jan 13, 2015

Conversation

mentiflectax
Copy link
Contributor

Issue URL: #8

@mentiflectax mentiflectax mentioned this pull request Jan 8, 2015
Closed
@dmarkov
Copy link

dmarkov commented Jan 12, 2015

Thanks, let me find someone who can review this pull request

@dmarkov
Copy link

dmarkov commented Jan 12, 2015

@krzyk please review

@mentiflectax
Copy link
Contributor Author

FYI: I merged changes from the jcabi-email master repository.

@yegor256
Copy link
Member

@krzyk please take a look (rather annoying bug, would be great to fix it asap)

krzyk
krzyk reviewed Jan 13, 2015
View reviewed changes
src/test/java/com/jcabi/email/EnvelopeTest.java
@@ -70,6 +74,42 @@ public void cachesPreviousCall() throws Exception {
}

/**
* Test for issue #8 (unicode/UTF-8 is broken).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write what the test does, not a link to issue

@mentiflectax
Copy link
Contributor Author

@krzyk Thanks for your feedback. I fixed the issues. Please look again.

krzyk
krzyk reviewed Jan 13, 2015
View reviewed changes
src/test/java/com/jcabi/email/EnvelopeTest.java
@@ -70,6 +73,43 @@ public void cachesPreviousCall() throws Exception {
}

/**
* Verifies that the encoding of the mail is set correctly and - as a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good description, but I think it is too long, let's go with: Envelope should handle non-Latin characters.

@krzyk
Copy link

krzyk commented Jan 13, 2015

@rultor merge pls

@rultor
Copy link
Contributor

rultor commented Jan 13, 2015

@rultor merge pls

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 445f70c into jcabi:master Jan 13, 2015
@rultor
Copy link
Contributor

rultor commented Jan 13, 2015

@rultor merge pls

@krzyk Done! FYI, the full log is here (took me 5min)

@mentiflectax mentiflectax deleted the task-8 branch January 13, 2015 11:36
@dmarkov
Copy link

dmarkov commented Jan 16, 2015

@krzyk 16 mins added to your account (payment number 50302477), many thanks for your contribution!. +16 to your rating, your total score is +1738

@dmarkov
Copy link

dmarkov commented Jan 16, 2015

@rultor deploy now pls

@rultor
Copy link
Contributor

rultor commented Jan 16, 2015

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 16, 2015

@rultor deploy now pls

@dmarkov Done! FYI, the full log is here (took me 2hr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mentiflectax @dmarkov @yegor256 @krzyk @rultor