Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#47 documentation update #48

Merged
merged 1 commit into from
Jul 22, 2016
Merged

#47 documentation update #48

merged 1 commit into from
Jul 22, 2016

Conversation

prondzyn
Copy link
Contributor

This PR is for issue #47.

I updated documentation files to be consistent with current SMTP constructor.

@dmarkov
Copy link

dmarkov commented Jul 20, 2016

@prondzyn Thanks, let me find someone who can review this pull request

@dmarkov
Copy link

dmarkov commented Jul 20, 2016

@carlosmiranda could you please review this PR

@carlosmiranda
Copy link

@rultor looks good to merge

@rultor
Copy link
Contributor

rultor commented Jul 20, 2016

@rultor looks good to merge

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@prondzyn
Copy link
Contributor Author

@yegor256 ping

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 22, 2016

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ad507de into jcabi:master Jul 22, 2016
@rultor
Copy link
Contributor

rultor commented Jul 22, 2016

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

@dmarkov
Copy link

dmarkov commented Jul 26, 2016

@carlosmiranda Thanks a lot, I just topped your account for 16 mins, transaction ID 94664842, total time was 118 hours and 54 mins

you're getting extra minutes here (c=1)

+16 added to your rating, at the moment it is: +2278

@dmarkov
Copy link

dmarkov commented Jul 26, 2016

@rultor deploy

@rultor
Copy link
Contributor

rultor commented Jul 26, 2016

@rultor deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Jul 26, 2016

@rultor deploy

@dmarkov Done! FYI, the full log is here (took me 4min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants