feat(#1663): fix all qulice suggestions

jcabi · Aug 4, 2023 · 6adb0e9 · 6adb0e9
1 parent e3c8a80
commit 6adb0e9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/src/main/java/com/jcabi/github/RepositoryStatistics.java b/src/main/java/com/jcabi/github/RepositoryStatistics.java
@@ -205,24 +205,24 @@ Object value(final JsonObject object) {
      * @author Volodya Lombrozo (volodya.lombrozo@gmail.com)
      * @since 1.8.0
      */
-    public static class Smart {
+    public static final class Smart {
 
         /**
          * Repository statistics.
          */
-        private final RepositoryStatistics stats;
+        private final transient RepositoryStatistics stats;
 
         /**
          * Public ctor.
-         * @param repo
+         * @param repo Repository.
          */
         public Smart(final Repo repo) {
             this(new RepositoryStatistics(repo));
         }
 
         /**
          * Public ctor.
-         * @param statistics
+         * @param statistics Repository statistics.
          */
         public Smart(final RepositoryStatistics statistics) {
             this.stats = statistics;

diff --git a/src/test/java/com/jcabi/github/RepositoryStatisticsTest.java b/src/test/java/com/jcabi/github/RepositoryStatisticsTest.java
@@ -50,7 +50,11 @@
  *  MkRepo should return different types like integer, double, long,
  *  etc. When it is implemented, we can replace strings with concrete
  *  types and remove that puzzle.
+ * @checkstyle StaticVariableNameCheck (1000 lines)
+ * @checkstyle MagicNumberCheck (1000 lines)
+ * @checkstyle LineLengthCheck (2 lines)
  */
+@SuppressWarnings({"PMD.SuspiciousConstantFieldName", "PMD.VariableNamingConventions"})
 public final class RepositoryStatisticsTest {
 
     /**
@@ -131,8 +135,7 @@ public final class RepositoryStatisticsTest {
     /**
      * Updated value in JSON.
      */
-    private static String UPDATED_VALUE = "2011-01-26T19:14:43Z";
-
+    private static String UPDATED_VALUE = "2012-01-26T19:14:43Z";
 
     /**
      * Checks that RepositryStatistics can convert all values to a map.
@@ -191,10 +194,14 @@ public void retrievesBasicStatisticsFromRepo()
         );
     }
 
+    /**
+     * Checks that RepositryStatistics.Smart can retrieve all values.
+     * @throws IOException If some problem with I/O happened.
+     */
     @Test
     public void retrievesSmartStatistics() throws IOException {
-        final RepositoryStatistics.Smart smart
-            = new RepositoryStatistics.Smart(this.repo());
+        final RepositoryStatistics.Smart smart =
+            new RepositoryStatistics.Smart(this.repo());
         MatcherAssert.assertThat(
             "Forks should be equal to 1",
             smart.forks(),
@@ -241,6 +248,11 @@ public void retrievesSmartStatistics() throws IOException {
         );
     }
 
+    /**
+     * Creates mock repo.
+     * @return Repo
+     * @throws IOException If some problem with I/O happened.
+     */
     private Repo repo() throws IOException {
         return new MkGithub()
             .repos()