Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtUserTest.java:484-488: Un-ignore this test and... #1401

Closed
0pdd opened this issue Apr 25, 2018 · 13 comments
Closed

RtUserTest.java:484-488: Un-ignore this test and... #1401

0pdd opened this issue Apr 25, 2018 · 13 comments

Comments

@0pdd
Copy link

0pdd commented Apr 25, 2018

The puzzle 1304-efe7c280 from #1304 has to be resolved:

* @todo #1304:30min Un-ignore this test and
* 'markAsReadErrorIfResponseStatusIsNot205' after refactoring to
* use an in-memory HTTP server (with MkGrizzly, from jcabi-http).
* You can configure the responses to give to any URI on
* MkGrizzlyContainer and then you can pass a custom Request to RtGithub.

The puzzle was created by Mihai A on 25-Apr-18.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented Apr 25, 2018

@amihaiemil/z please, pay attention to this issue

@0crat
Copy link

0crat commented Apr 25, 2018

@0pdd/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@0crat 0crat added the scope label Apr 25, 2018
@0crat
Copy link

0crat commented Apr 25, 2018

Job #1401 is now in scope, role is DEV

@0crat
Copy link

0crat commented May 6, 2018

The job #1401 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@llorllale
Copy link
Contributor

@amihaiemil what's wrong with using FkRequest?

@amihaiemil
Copy link
Member

amihaiemil commented May 8, 2018

@llorllale I think FkRequest does not give you the option to specify the URI, it just calls localhost:80. But if you use MkGrizzly http server, then you can mock URIs and their responses, and just use ApacheRequest with localhost:{grizzly_port}/mock/path to fake the request and get the response.

This task originated from this idea. We shouldn't use the Mk* classes in the library to test the Rt* classes :)

@amihaiemil
Copy link
Member

@llorllale nevertheless, do it as simple as possible. If you find a way of using FkRequest and don't need the mock server, do it like that, I have no problem :D Just don't forget about PDD. This can be a research task as well, if you must study how MkGrizzly works in other tests.

@0crat
Copy link

0crat commented May 11, 2018

@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

llorllale added a commit to llorllale/jcabi-github that referenced this issue May 14, 2018
…markAsReadErrorIfResponseStatusIsNot205

 so that MkGrizzlyContainer is used for tests instead of FakeRequest.
@llorllale
Copy link
Contributor

@0crat waiting on review/merge for #1411

@0crat
Copy link

0crat commented May 14, 2018

@0crat waiting on review/merge for #1411 (here)

@llorllale The impediment for #1401 was registered successfully by @llorllale/z

@0pdd
Copy link
Author

0pdd commented May 15, 2018

The puzzle 1304-efe7c280 has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link

0crat commented May 15, 2018

Order was finished: +30 point(s) just awarded to @llorllale/z

@0crat
Copy link

0crat commented May 15, 2018

The job #1401 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants