Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MkStorageTest.java:51-53: Three test are skipped here... #934

Closed
dmarkov opened this issue Dec 11, 2014 · 5 comments
Closed

MkStorageTest.java:51-53: Three test are skipped here... #934

dmarkov opened this issue Dec 11, 2014 · 5 comments
Labels
30 mins

Comments

@dmarkov
Copy link

dmarkov commented Dec 11, 2014

Puzzle 930-31980d5f in src/test/java/com/jcabi/github/mock/MkStorageTest.java:51-53 has to be resolved: Three test are skipped here because MkStorage.Synced is not immutable. Its properly ReentrantLock is not immutable. Let's find a way to implement it differently and make that class truly immutable.

If you have any technical questions, don't ask me, submit new tickets instead
@dmarkov
Copy link
Author

dmarkov commented Dec 11, 2014

@longtimeago the issue is yours, please help

longtimeago added a commit to longtimeago/jcabi-github that referenced this issue Dec 15, 2014
@longtimeago
Issue jcabi#934 Immutable reentrant lock
bfb6428
@longtimeago
Copy link
Contributor

PR #937 is available for review

longtimeago added a commit to longtimeago/jcabi-github that referenced this issue Dec 16, 2014
@longtimeago
Issue jcabi#934 Fixed checkstyle violations
693f041
longtimeago added a commit to longtimeago/jcabi-github that referenced this issue Dec 16, 2014
@longtimeago
Issue jcabi#934 Fixed import
2e98a9d
@longtimeago
Copy link
Contributor

@dmarkov please, close the issue. Thanks

@dmarkov dmarkov closed this as completed Dec 22, 2014
@dmarkov
Copy link
Author

dmarkov commented Dec 22, 2014

It's closed now

@dmarkov
Copy link
Author

dmarkov commented Dec 22, 2014

@longtimeago thanks, paid, 30 mins to your account, payment ID is 49190736

@dmarkov dmarkov mentioned this issue Jan 21, 2015
Closed
@carlosmiranda carlosmiranda mentioned this issue Mar 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longtimeago @dmarkov