Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "List Branches" API #1085

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Implement "List Branches" API #1085

merged 2 commits into from
Jun 2, 2015

Conversation

cvrebert
Copy link
Contributor

Fixes #1084 by adding Repo.branches(), which returns a Branches, which has a Branches.iterate() method, which returns an iterator of Branch objects representing all branches in the repository using the relevant GitHub API endpoint.

@dmarkov
Copy link

dmarkov commented May 26, 2015

@cvrebert Thanks for the pull request, let me find a reviewer..

@dmarkov
Copy link

dmarkov commented May 26, 2015

@ggajos please review this one

* @param repo Repository
* @param nom Name of branch
* @param sha Commit SHA hash
* @checkstyle ParameterNumberCheck (6 lines)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvrebert maybe let's add PDD here to decrease number of args?

@ggajos
Copy link

ggajos commented May 26, 2015

@cvrebert few comments

@cvrebert
Copy link
Contributor Author

@ggajos I've addressed all of your comments.

@ggajos
Copy link

ggajos commented May 26, 2015

@cvrebert build is failing now

@cvrebert
Copy link
Contributor Author

@ggajos Fixed.

@ggajos
Copy link

ggajos commented May 27, 2015

@cvrebert thanks

@ggajos
Copy link

ggajos commented May 27, 2015

@rultor merge

@ggajos
Copy link

ggajos commented May 27, 2015

@cvrebert looks really good

@rultor
Copy link
Contributor

rultor commented May 27, 2015

@rultor merge

@ggajos Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Member

@rultor try to merge

@rultor
Copy link
Contributor

rultor commented May 27, 2015

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented May 27, 2015

@rultor try to merge

@yegor256 Oops, I failed. You can see the full log here (spent 11min)

INFO: "reading src/test/java/com/jcabi/github/mock/MkDeployKeysTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkEventTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkForkTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkForksTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkGistTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkGistsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkGitTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkGithubTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkGitignoresTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkHooksTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkIssueEventsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkIssueLabelsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkIssueTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkIssuesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkLabelsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkLimitsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkMarkdownTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkMilestoneTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkMilestonesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkOrganizationsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPublicKeyTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPublicKeysTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPullCommentTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPullCommentsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPullTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkPullsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReferenceTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReferencesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReleaseAssetTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReleaseAssetsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReleaseTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReleasesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkRepoCommitTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkRepoCommitsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkRepoTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkReposTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkSearchTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkStarsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkStorageTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkTagTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkTagsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkTreeTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkTreesTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkUserEmailsTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/MkUserTest.java..."
INFO: "reading src/test/java/com/jcabi/github/mock/package-info.java..."
INFO: "reading src/test/java/com/jcabi/github/package-info.java..."
INFO: "reading src/test/java/com/jcabi/github/wire/CarefulWireTest.java..."
INFO: "reading src/test/java/com/jcabi/github/wire/RetryCarefulWireTest.java..."
INFO: "reading src/test/java/com/jcabi/github/wire/package-info.java..."
INFO: "reading src/test/resources/META-INF/MANIFEST.MF..."
INFO: "reading src/test/resources/META-INF/services/javax.xml.parsers.DocumentBuilderFactory..."
INFO: "reading src/test/resources/log4j.properties..."
ERROR: "there are 2 duplicate(s) of the same puzzle: src/main/java/com/jcabi/github/RtBranch.java:75-76, src/main/java/com/jcabi/github/mock/MkBranch.java:78-79, while maximum 1 duplicate is allowed"
/var/lib/gems/1.9.1/gems/pdd-0.14.2/lib/pdd.rb:150:in `rules': 1 errors, see log above (PDD::Error)
    from /var/lib/gems/1.9.1/gems/pdd-0.14.2/lib/pdd.rb:105:in `xml'
    from /var/lib/gems/1.9.1/gems/pdd-0.14.2/bin/pdd:90:in `<top (required)>'
    from /usr/local/bin/pdd:23:in `load'
    from /usr/local/bin/pdd:23:in `<main>'

@cvrebert
Copy link
Contributor Author

@yegor256 I rephrased the one @todo to work around that silly PDD restriction. Please retry the merge.

@yegor256
Copy link
Member

@rultor try to merge again

@rultor
Copy link
Contributor

rultor commented May 28, 2015

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented May 28, 2015

@rultor try to merge again

@yegor256 Oops, I failed. You can see the full log here (spent 4min)

[INFO] [INFO] Finished at: 2015-05-28T01:26:02+00:00
[INFO] [INFO] Final Memory: 18M/276M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "qulice" could not be activated because it does not exist.
[INFO] ..SUCCESS (6.3 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 2, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ jcabi-github ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:29 min
[INFO] Finished at: 2015-05-28T01:26:02+00:00
[INFO] Final Memory: 48M/465M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:194)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@yegor256
Copy link
Member

yegor256 commented Jun 1, 2015

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor merge

@yegor256 Oops, I failed. You can see the full log here (spent 3min)

[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.081 s
[INFO] Finished at: 2015-06-01T19:46:09+00:00
[INFO] Final Memory: 35M/439M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project jcabi-github: Compilation failure: Compilation failure:
[ERROR] /home/r/repo/src/test/java/com/jcabi/github/RtBranchTest.java:[122,47] method create in interface com.jcabi.github.Repos cannot be applied to given types;
[ERROR] required: com.jcabi.github.Repos.RepoCreate
[ERROR] found: javax.json.JsonObject
[ERROR] reason: actual argument javax.json.JsonObject cannot be converted to com.jcabi.github.Repos.RepoCreate by method invocation conversion
[ERROR] /home/r/repo/src/test/java/com/jcabi/github/mock/MkBranchesTest.java:[64,72] method create in interface com.jcabi.github.Repos cannot be applied to given types;
[ERROR] required: com.jcabi.github.Repos.RepoCreate
[ERROR] found: javax.json.JsonObject
[ERROR] reason: actual argument javax.json.JsonObject cannot be converted to com.jcabi.github.Repos.RepoCreate by method invocation conversion
[ERROR] /home/r/repo/src/test/java/com/jcabi/github/mock/MkBranchesTest.java:[82,73] method create in interface com.jcabi.github.Repos cannot be applied to given types;
[ERROR] required: com.jcabi.github.Repos.RepoCreate
[ERROR] found: javax.json.JsonObject
[ERROR] reason: actual argument javax.json.JsonObject cannot be converted to com.jcabi.github.Repos.RepoCreate by method invocation conversion
[ERROR] /home/r/repo/src/test/java/com/jcabi/github/mock/MkBranchTest.java:[104,47] method create in interface com.jcabi.github.Repos cannot be applied to given types;
[ERROR] required: com.jcabi.github.Repos.RepoCreate
[ERROR] found: javax.json.JsonObject
[ERROR] reason: actual argument javax.json.JsonObject cannot be converted to com.jcabi.github.Repos.RepoCreate by method invocation conversion
[ERROR] /home/r/repo/src/test/java/com/jcabi/github/RtBranchesTest.java:[152,47] method create in interface com.jcabi.github.Repos cannot be applied to given types;
[ERROR] required: com.jcabi.github.Repos.RepoCreate
[ERROR] found: javax.json.JsonObject
[ERROR] reason: actual argument javax.json.JsonObject cannot be converted to com.jcabi.github.Repos.RepoCreate by method invocation conversion
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project jcabi-github: Compilation failure
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
    at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:858)
    at org.apache.maven.plugin.compiler.TestCompilerMojo.execute(TestCompilerMojo.java:152)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 1, 2015

Sorry about that, there was a conflict with the other just-merged PR. Fixed now.

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

Sorry about that, there was a conflict with the other just-merged PR. Fixed now.

@rultor merge

@cvrebert I see you're talking about me, but I don't understand it. If you want to say something to me directly, start a message with @rultor

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 1, 2015

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor merge

@cvrebert Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Member

yegor256 commented Jun 1, 2015

@rultor try to merge again

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor try to merge again

@yegor256 Oops, I failed. You can see the full log here (spent 8min)

[INFO] [INFO] Finished at: 2015-06-01T20:04:43+00:00
[INFO] [INFO] Final Memory: 21M/391M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "qulice" could not be activated because it does not exist.
[INFO] ..SUCCESS (12.8 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 2, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ jcabi-github ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2015-06-01T20:04:44+00:00
[INFO] Final Memory: 44M/421M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:194)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 1, 2015

Error is unrelated:

Failed tests: RtMilestonesITCase.iteratesIssues:101 HTTP response status is not equal to 201: 400 Bad Request [https://api.github.com/repos/jcabi-github-test2/cevc7Mocvb/milestones]
[...]
{"message":"Problems parsing JSON","documentation_url":"https://developer.github.com/v3"}

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 1, 2015

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 1, 2015

@rultor merge

@cvrebert Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Member

yegor256 commented Jun 2, 2015

@rultor merge pls

@rultor
Copy link
Contributor

rultor commented Jun 2, 2015

@rultor merge pls

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c7e9f92 into jcabi:master Jun 2, 2015
@rultor
Copy link
Contributor

rultor commented Jun 2, 2015

@rultor merge pls

@yegor256 Done! FYI, the full log is here (took me 10min)

@cvrebert cvrebert deleted the impl-branches branch June 2, 2015 00:55
@dmarkov
Copy link

dmarkov commented Jun 4, 2015

@ggajos Thank you, I have added 20 mins to your account in payment/transaction "AP-2AC6673580791644L", time consumed: 167 hours and 56 mins. you're getting extra minutes here (c=5). +20 added to your rating, current score is: +1611

@dmarkov
Copy link

dmarkov commented Jun 4, 2015

@rultor please deploy

@rultor
Copy link
Contributor

rultor commented Jun 4, 2015

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 4, 2015

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 8min)

@dmarkov
Copy link

dmarkov commented Jun 4, 2015

@cvrebert 2 puzzles were created here: 1085-6b1095b1, 1085-a13e40d1

@0pdd
Copy link

0pdd commented Dec 11, 2018

@cvrebert the puzzle #unknown is still not solved.

@0pdd
Copy link

0pdd commented Jul 5, 2022

@cvrebert the puzzle #1559 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"List branches" API is missing
6 participants