#1017 RtForkTest.java:56-58: Apply this rule to other #1166

tmjee · 2015-09-23T22:17:48Z

TS/PDD #1017

fix indention
added todo puzzle to redesign RtBlobsTest and remove checkstyle

dmarkov · 2015-09-24T09:23:47Z

@tmjee Let me find a reviewer for this pull request, thanks for submitting it

dmarkov · 2015-09-24T09:27:57Z

@darkled it's yours, please review

asaen · 2015-09-24T11:26:55Z

src/test/java/com/jcabi/github/RtBlobsTest.java

@@ -63,8 +74,9 @@ public void canCreateBlob() throws Exception {
        final String content = "Content of the blob";
        final String body = blob().toString();
        final MkContainer container = new MkGrizzlyContainer().next(
-            new MkAnswer.Simple(HttpURLConnection.HTTP_CREATED, body)
-        ).next(new MkAnswer.Simple(HttpURLConnection.HTTP_OK, body)).start();
+                new MkAnswer.Simple(HttpURLConnection.HTTP_CREATED, body)


@tmjee indentations seems to be not correct here

asaen · 2015-09-24T11:32:42Z

@tmjee please see a minor comment above. Also please change the PR according to our quality rules:

Pull request title explains the problem it is fixing.

Pull request description explains the solution proposed and contains a link to the original ticket it is related to.

tmjee · 2015-09-24T12:19:52Z

@darkled Changes made, details updated. Thx

asaen · 2015-09-24T12:22:02Z

@tmjee great, thanks

asaen · 2015-09-24T12:22:08Z

@rultor merge pls

rultor · 2015-09-24T12:23:03Z

@rultor merge pls

@darkled Thanks for your request. @yegor256 Please confirm this.

yegor256 · 2015-09-25T15:08:24Z

@rultor try to merge

rultor · 2015-09-25T15:09:19Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-09-25T15:16:01Z

@rultor try to merge

@tmjee @yegor256 Oops, I failed. You can see the full log here (spent 7min)

[INFO] [INFO] Finished at: 2015-09-25T15:15:21+00:00
[INFO] [INFO] Final Memory: 20M/391M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "qulice" could not be activated because it does not exist.
[INFO] ..SUCCESS (10.7 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 2, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ jcabi-github ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:12 min
[INFO] Finished at: 2015-09-25T15:15:22+00:00
[INFO] Final Memory: 51M/455M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:194)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

asaen · 2015-09-25T16:29:46Z

@yegor256 there is some accidental error, could you try to merge once more, please?

yegor256 · 2015-09-25T22:22:45Z

@darkled every time you see such an error, it's a good practice to create a ticket, complaining about tests instability.

yegor256 · 2015-09-25T22:22:50Z

@rultor try to merge again

rultor · 2015-09-25T22:23:38Z

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-09-25T22:31:32Z

@rultor try to merge again

@tmjee @yegor256 Oops, I failed. You can see the full log here (spent 8min)

[INFO] [INFO] Finished at: 2015-09-25T22:30:01+00:00
[INFO] [INFO] Final Memory: 15M/391M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [WARNING] The requested profile "qulice" could not be activated because it does not exist.
[INFO] ..SUCCESS (13.7 s)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 2, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO] 
[INFO] --- maven-failsafe-plugin:2.17:verify (default) @ jcabi-github ---
[INFO] Failsafe report directory: /home/r/repo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:41 min
[INFO] Finished at: 2015-09-25T22:30:02+00:00
[INFO] Final Memory: 39M/450M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (default) on project jcabi-github: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/failsafe-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.failsafe.VerifyMojo.execute(VerifyMojo.java:194)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

asaen · 2015-09-26T09:14:37Z

@tmjee please take a look at

Tests in error: RtIssueITCase.talksInGithubProject:107 » ClassCast javax.json.JsonValue$1 cann...

It seems something is broken.

tmjee · 2015-09-26T09:27:44Z

@darkled Can I get more details about the error? Eg. a copy of the logs / stack traces for the test in /home/r/repo/target/failsafe-reports directory. Thx

asaen · 2015-09-26T09:30:16Z

@tmjee you can find all the information in the rultor's merge log, link is mentioned above.

tmjee · 2015-09-26T09:35:58Z

@darkled the log mentioned

There are test failures. 
Please refer to /home/r/repo/target/failsafe-reports for the individual test results.

I'd like to get that test RtIssueITCase.talksInGithubProject test results. It is not in rultor's merge log because that single CCE doesn't makes much sense looking at the code at that line. I am just curious how no change in code causes integration tests to fail. I suspect some comms issue is causing this CCE.

asaen · 2015-09-26T09:40:58Z

@tmjee please see http://www.rultor.com/t/5241-143366877, I think it should be enough. Also I am not sure if we have access to /home/r/repo/target/failsafe-reports, because rultor uses docker container for every build.

tmjee · 2015-09-26T10:33:37Z

@darkled see #1168 for more info. This is another separate issue. Please try run merge again and it should work.

asaen · 2015-09-26T13:53:47Z

@tmjee ok, then please ignore (with @Ignore) this test and let's try to merge once more

asaen · 2015-10-05T12:05:19Z

@tmjee is there any news?

tmjee · 2015-10-05T13:12:51Z

@darkled done.

asaen · 2015-10-05T18:41:57Z

@tmjee I think we need to wait a bit till #1162 is merged, it has similar problem

amihaiemil · 2018-04-02T11:24:21Z

@asaen I am closing this; it's way too big, too many changes, and too old. I'm pretty sure it would be faster to redo the PR than fixing all the conflicts and making sure changes are up to date...

0crat · 2018-04-02T11:39:29Z

The job is not in WBS, won't close the order

#1017

96414ad

tmjee mentioned this pull request Sep 24, 2015

RtForkTest.java:56-58: Apply this rule to other... #1017

Closed

dmarkov added CR @darkled labels Sep 24, 2015

dmarkov assigned asaen Sep 24, 2015

dmarkov added the 15 mins label Sep 24, 2015

asaen reviewed Sep 24, 2015
View reviewed changes

#1017

216b414

tmjee changed the title ~~#1017~~ #1017 RtForkTest.java:56-58: Apply this rule to other Sep 24, 2015

issue #1017

564fa97

Issue #1017

070f19c

amihaiemil closed this Apr 2, 2018

amihaiemil unassigned asaen Apr 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1017 RtForkTest.java:56-58: Apply this rule to other #1166

#1017 RtForkTest.java:56-58: Apply this rule to other #1166

tmjee commented Sep 23, 2015

dmarkov commented Sep 24, 2015

dmarkov commented Sep 24, 2015

asaen Sep 24, 2015

asaen commented Sep 24, 2015

tmjee commented Sep 24, 2015

asaen commented Sep 24, 2015

asaen commented Sep 24, 2015

rultor commented Sep 24, 2015

yegor256 commented Sep 25, 2015

rultor commented Sep 25, 2015

rultor commented Sep 25, 2015

asaen commented Sep 25, 2015

yegor256 commented Sep 25, 2015

yegor256 commented Sep 25, 2015

rultor commented Sep 25, 2015

rultor commented Sep 25, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

asaen commented Oct 5, 2015

tmjee commented Oct 5, 2015

asaen commented Oct 5, 2015

amihaiemil commented Apr 2, 2018

0crat commented Apr 2, 2018

#1017 RtForkTest.java:56-58: Apply this rule to other #1166

#1017 RtForkTest.java:56-58: Apply this rule to other #1166

Conversation

tmjee commented Sep 23, 2015

dmarkov commented Sep 24, 2015

dmarkov commented Sep 24, 2015

asaen Sep 24, 2015

Choose a reason for hiding this comment

asaen commented Sep 24, 2015

tmjee commented Sep 24, 2015

asaen commented Sep 24, 2015

asaen commented Sep 24, 2015

rultor commented Sep 24, 2015

yegor256 commented Sep 25, 2015

rultor commented Sep 25, 2015

rultor commented Sep 25, 2015

asaen commented Sep 25, 2015

yegor256 commented Sep 25, 2015

yegor256 commented Sep 25, 2015

rultor commented Sep 25, 2015

rultor commented Sep 25, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

tmjee commented Sep 26, 2015

asaen commented Sep 26, 2015

asaen commented Oct 5, 2015

tmjee commented Oct 5, 2015

asaen commented Oct 5, 2015

amihaiemil commented Apr 2, 2018

0crat commented Apr 2, 2018