Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checks to Pull interface #1620

Merged
merged 2 commits into from Mar 21, 2023
Merged

Conversation

volodya-lombrozo
Copy link
Contributor

I've added Checks to the Pull interface to be able retrieve them

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you take a look, please?

@yegor256
Copy link
Member

@volodya-lombrozo it's a good practice to use @since JavaDoc markers when you add new classes and methods. They will help users understand which version they need if they except certain functionality.

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 I've added missing @since comments. could you have a look, again, please?

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Reminder

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 21, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f6871d6 into jcabi:master Mar 21, 2023
5 of 8 checks passed
@rultor
Copy link
Contributor

rultor commented Mar 21, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you release a new version please? 1.6.0 or 1.5.1 I guess

@yegor256
Copy link
Member

@rultor release, tag is 1.6.0

@rultor
Copy link
Contributor

rultor commented Mar 21, 2023

@rultor release, tag is 1.6.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 21, 2023

@rultor release, tag is 1.6.0

@yegor256 Done! FYI, the full log is here (took me 38min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants