Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SQLException handling to documentation #70

Closed
sz332 opened this issue Apr 6, 2019 · 30 comments
Closed

Add missing SQLException handling to documentation #70

sz332 opened this issue Apr 6, 2019 · 30 comments

Comments

@sz332
Copy link

sz332 commented Apr 6, 2019

In the current version of the library (0.17.2) the JDBCSession.select() methods throws a checked SQLException, but in the documentation (for example here: https://github.com/jcabi/jcabi-jdbc, or here: https://jdbc.jcabi.com/example-select.html) it is not handled.

As a developer I find it misleading.

@0crat
Copy link

0crat commented Apr 6, 2019

@yegor256/z please, pay attention to this issue

@0crat
Copy link

0crat commented Apr 6, 2019

@sz332/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@yegor256
Copy link
Member

yegor256 commented May 5, 2019

@sz332 you are right. Would you be interested in submitting a pull request to fix this?

@yegor256 yegor256 added the bug label May 5, 2019
@0crat 0crat added the scope label May 5, 2019
@0crat
Copy link

0crat commented May 5, 2019

Job #70 is now in scope, role is DEV

@0crat
Copy link

0crat commented May 5, 2019

Thanks for your contribution, @sz332/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@sz332
Copy link
Author

sz332 commented May 5, 2019

@sz332 you are right. Would you be interested in submitting a pull request to fix this?

@yegor256
Sure. Is it enough to fork the project, make the modification, and send a pull request?

@0crat
Copy link

0crat commented May 5, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 10, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 15, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 20, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 25, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 30, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 5, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 10, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 15, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 20, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jun 25, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

yegor256 commented Jul 4, 2019

@sz332 yes, just create a pull request and I will merge. Don't forget to run mvn -Pqulice clean install

@0crat
Copy link

0crat commented Jul 5, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 10, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 15, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 20, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 25, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Jul 30, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 4, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 9, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 14, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 19, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 24, 2019

@yegor256/z everybody who has role DEV is banned at #70; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 added a commit that referenced this issue Jun 10, 2023
@yegor256
Copy link
Member

@sz332 fixed as you suggested: 58f96e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants