Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SizeDecorTest.java:66-68: The SizeDecor class is not... #25

Closed
dmarkov opened this issue Aug 18, 2014 · 7 comments
Closed

SizeDecorTest.java:66-68: The SizeDecor class is not... #25

dmarkov opened this issue Aug 18, 2014 · 7 comments
Labels
30 mins @carlosmiranda

Comments

@dmarkov
Copy link

dmarkov commented Aug 18, 2014

Puzzle 26-9c2568b0 in src/test/java/com/jcabi/log/SizeDecorTest.java:66-68 has to be resolved: The SizeDecor class is not implemented yet, that's why the test is not enabled at the moment. You should uncomment the lines below and make sure the test passes.
@dmarkov
Copy link
Author

dmarkov commented Aug 18, 2014

@carlosmiranda please help, the task is yours

carlosmiranda added a commit to carlosmiranda/jcabi-log that referenced this issue Aug 19, 2014
@carlosmiranda
jcabi#25 Implemented SizeDecor
26c3188
carlosmiranda added a commit to carlosmiranda/jcabi-log that referenced this issue Aug 19, 2014
@carlosmiranda
jcabi#25 Included Eb suffix (max range of long)
997ffd5
carlosmiranda added a commit to carlosmiranda/jcabi-log that referenced this issue Aug 19, 2014
@carlosmiranda
jcabi#25 Changed StringBuilder to String.format for better clarity
88ea9d5
@carlosmiranda
Copy link
Contributor

Pull request submitted for review: #28.

@carlosmiranda
Copy link
Contributor

@dmarkov @yegor256 #28 has been merged, could this be closed and paid for now?

@dmarkov dmarkov closed this as completed Aug 25, 2014
@dmarkov
Copy link
Author

dmarkov commented Aug 25, 2014

Thanks all, closed

@carlosmiranda
Copy link
Contributor

@dmarkov @yegor256 this is not paid for yet...

@carlosmiranda
Copy link
Contributor

@dmarkov @yegor256 any reason why this has not been paid for yet? I haven't been paid for any closed tasks for a week now...

@dmarkov
Copy link
Author

dmarkov commented Aug 29, 2014

@carlosmiranda I just added 30 mins to your account, many thanks for your contribution..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins @carlosmiranda
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosmiranda @dmarkov