Stream closed exception in logs

[yegor256]

When plugin shuts down, this is what I see in logs:

[WARNING] escalated exception: java.lang.IllegalArgumentException: java.io.IOException: Stream closed
    at com.jcabi.log.VerboseRunnable$1.run(VerboseRunnable.java:142)
    at com.jcabi.log.VerboseRunnable.run(VerboseRunnable.java:201)
    at java.lang.Thread.run(Thread.java:701)
Caused by: java.io.IOException: Stream closed
    at java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
    at java.io.BufferedInputStream.read1(BufferedInputStream.java:272)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
    at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:282)
    at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:324)
    at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:176)
    at java.io.InputStreamReader.read(InputStreamReader.java:184)
    at java.io.BufferedReader.fill(BufferedReader.java:153)
    at java.io.BufferedReader.readLine(BufferedReader.java:316)
    at java.io.BufferedReader.readLine(BufferedReader.java:379)
    at com.jcabi.log.VerboseProcess$1.call(VerboseProcess.java:260)
    at com.jcabi.log.VerboseProcess$1.call(VerboseProcess.java:249)
    at com.jcabi.log.VerboseRunnable$1.run(VerboseRunnable.java:139)
    ... 2 more

Doesn't affect anything, but is rather annoying. Would be great to fix.

[dmarkov]

I'm aware of the task, give me some time to find a developer...

[dmarkov]

thanks for the report, I topped your acc for 15 mins, payment ID 000-900d0524

[dmarkov]

@longtimeago the issue is yours, please help

[longtimeago]

@yegor256 As far as I see, this is jcabi-log issue.
With current version it looks a bit different:

[warn] escalated exception: java.lang.IllegalArgumentException: java.io.IOException: Stream closed
    at com.jcabi.log.VerboseRunnable$1.run(VerboseRunnable.java:142)
    at com.jcabi.log.VerboseRunnable.run(VerboseRunnable.java:201)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: Stream closed
    at java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
    at java.io.BufferedInputStream.read1(BufferedInputStream.java:272)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
    at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:283)
    at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:325)
    at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:177)
    at java.io.InputStreamReader.read(InputStreamReader.java:184)
    at java.io.BufferedReader.fill(BufferedReader.java:154)
    at java.io.BufferedReader.readLine(BufferedReader.java:317)
    at java.io.BufferedReader.readLine(BufferedReader.java:382)
    at com.jcabi.log.VerboseProcess$Monitor.call(VerboseProcess.java:336)
    at com.jcabi.log.VerboseProcess$Monitor.call(VerboseProcess.java:288)
    at com.jcabi.log.VerboseRunnable$1.run(VerboseRunnable.java:139)
    ... 2 more

We can catch IOException when trying to read from stream and swallow it

[yegor256]

I think it's a bug in VerboseProcess: jcabi/jcabi-log#36

[longtimeago]

@yegor256 So, we don't need this issue

[yegor256]

well, as soon that original problem is fixed, we'll have to update jcabi-log here and re-check again

[longtimeago]

@dmarkov Waiting for jcabi/jcabi-log#36

[longtimeago]

@yegor256 waiting for jcabi/jcabi-log#36

[yegor256]

@dmarkov we need more time here

[dmarkov]

@dmarkov we need more time here

@yegor256 of course, thanks for letting me know, take your time

[longtimeago]

@yegor256 I've upgraded the project to log 0.15.1 (locally) and exception now looks like this:

[error] Error reading from process stream: java.io.IOException: Stream closed
    at java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
    at java.io.BufferedInputStream.read1(BufferedInputStream.java:272)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
    at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:283)
    at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:325)
    at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:177)
    at java.io.InputStreamReader.read(InputStreamReader.java:184)
    at java.io.BufferedReader.fill(BufferedReader.java:154)
    at java.io.BufferedReader.readLine(BufferedReader.java:317)
    at java.io.BufferedReader.readLine(BufferedReader.java:382)
    at com.jcabi.log.VerboseProcess$Monitor.call(VerboseProcess.java:357)
    at com.jcabi.log.VerboseProcess$Monitor.call(VerboseProcess.java:314)
    at com.jcabi.log.VerboseRunnable$1.run(VerboseRunnable.java:133)
    at com.jcabi.log.VerboseRunnable.run(VerboseRunnable.java:198)
    at java.lang.Thread.run(Thread.java:745)

Looks like we can't avoid it.
Should I create PR with this change?

[yegor256]

yeah, create a pull request pls

[longtimeago]

@yegor256 Here it is #53

[longtimeago]

@yegor256 Finally, we can close this long issue, if you are OK.

[yegor256]

thanks!

[longtimeago]

@yegor256 The issue is closed, but still not payed. Is there anything wrong?

[longtimeago]

@yegor256 ping :)

[yegor256]

@longtimeago let me check...

[longtimeago]

@yegor256 ping :)

[longtimeago]

@yegor256 Any news here?

[longtimeago]

@yegor256 need your attention here. Closed month ago but still in the list of tasks on netbout

[yegor256]

@longtimeago it'll be closed/paid tomorrow the latest. there were some issues, resolved them already

[longtimeago]

@yegor256 great, thanks!

[dmarkov]

@longtimeago 30 mins added to your account (payment number 50616319), many thanks for your contribution!... +30 added to your rating, at the moment it is: +1367