Adds label_color as an option to line charts. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a setting for the label colour in line charts, allowing users to override the default black label with a hex colour when creating a line chart. This is done by overriding the LabelSet's "Draw" method for Y axis labels, and by adding an @option to the "draw_x_label" LineChart class. If no label colour is provided the default colour '#333' is used.
This commit adds axis names to line charts, allowing you to show labels with
the names underneath the graph. You can name graph axis by doing the following:
chart = new Charts.LineChart('graph', {
y_axis_name: 'Conversion Rate',
x_axis_name: 'Date',
axis_name_color: '#aaa',
axis_name_size: 10,
x_padding: 60,
});
There are options for the axis names, the axis font colour and the axis text
size to differentiate these from the labels for data values.
Note that right now you'll ahve to tweak X padding to work with your text size
for the Y axis.
|
Hey, I wanted to make a separate branch and pull request for commit 0f3d496 though it has conflicts with the label colour commit (86c349c) so it's in this pull request, too. The second commit allows (0f3d496) you to add axis names as part of the line graph options which adds a label to the graph like this: I've tested this across IE (7–9), FireFox, Opera, Safari and Chrome and it all works OK with different font sizes (x_padding needs to be adjusted manually for space for the font). |
|
Also, this fixes issue #5 :) |
|
Hey Tony, thanks for the pull looks good. I'll test it out tonight and merge it in. |
|
Awesome! Let me know if you need me to do anything and I'll try and help. |
jcarver989
added a commit
that referenced
this pull request
Mar 22, 2013
Adds label_color as an option to line charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Josh,
This commit adds a setting for the label colour in line charts, allowing users to override the default black label with a hex colour when creating a line chart. This is done by adding a "color" method to the LabelSet class which changes the @color property, and by adding a "label_color" @option to the "draw_x_label" method in the LineChart class.
Changing the "label_color" option for a line graph changes the color of all labels, like so:
If no label colour is provided the default colour '#333' is used.