Add Windows support for Qt 5.10.0 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesobutler
force-pushed
the
5.10.0-Windows
branch
from
df3297f
to
3615492
Compare
|
@jamesobutler I merged this one ... I am wondering if there any useful bit to port over to 5.15.1 |
|
Same response as #28 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updated work that supersedes PR #28 to match the new branch structure in this repo.
I've made sure to configure Qt like the macOS and Linux builds. Please confirm that it is correct. URL links have already been changed to point to the location it would be in your repo.
I've tested a Qt 5.10.0 MSVC2015 build which succeeded, though when using it during the slicer configuration process I noticed it was missing Qt5Qml and Qt5Quick directories. Not sure what the issue is there. If you can set up auto building for this that would be great.
Also the OpenSSL binaries are for version 1.0.2k which I compiled and uploaded to the kitware midas server back at the time of my original PR. Note this is a different from 1.0.2n which is used in the macOS and Linux builds. It is probably best for you to build and upload those scripts to the correct location in the kitware midas server if you want to use the same OpenSSL versions.
This adds the Windows platform updates for #15.
xref #44