Add metrics interfaces and members, to demo a way to offer metrics wihout tying down to a specific implementation #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spiked up a quick demo of what I would say is a reasonable way to offer metrics support in Pushy, without tying that down to a specific backend implementation too tightly.
This should allow implementation against:
Essentially, the API used by Pushy internally is a simplified version of the Metrics API, but should be implementable for statsd and Datadog easily enough too. I'd be curious if there are other metrics systems this approach would pose a problem for....