Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics interfaces and members, to demo a way to offer metrics wihout tying down to a specific implementation #222

Closed
wants to merge 3 commits into from

Conversation

jmason
Copy link

@jmason jmason commented Jan 25, 2016

I've spiked up a quick demo of what I would say is a reasonable way to offer metrics support in Pushy, without tying that down to a specific backend implementation too tightly.

This should allow implementation against:

Essentially, the API used by Pushy internally is a simplified version of the Metrics API, but should be implementable for statsd and Datadog easily enough too. I'd be curious if there are other metrics systems this approach would pose a problem for....

…thout tying down to a specific implementation.
@jmason jmason mentioned this pull request Jan 25, 2016
@jchambers
Copy link
Owner

@jmason Thanks a million for this!

For the audience at home, this led to a great discussion in #175. We decided to pursue a slightly different approach (see #251), but that approach is very much inspired by this demo.

I'm going to close this, since I think it's served its purpose admirably. Thanks again!

@jchambers jchambers closed this Mar 12, 2016
@jmason
Copy link
Author

jmason commented Mar 14, 2016

cheers Jon ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants