JCLOUDS-1122: Support subnetworks definitions in Google Compute. #1006
Conversation
| Iterator<String> subnetworks = options.getSubnetworks().iterator(); | ||
|
|
||
| URI subnetwork = subnetworks.hasNext() ? URI.create(subnetworks.next()) : null; | ||
| assert !subnetworks.hasNext() : "Error: Options should specify only one subnetwork"; |
There was a problem hiding this comment.
Since this is an option specific to google (unlike "networks" that is in the jclouds portable interface), make it just an URI instead of a collection, to avoid unnecessary configuration issues.
There was a problem hiding this comment.
I made a collection like networks because like networks it can be specified more than once.
I added the blocker to match networks behavior though, but I'll create a separate PR to remove both and bring multiple interfaces (direct or subnetworked) to the module.
|
Thanks @nelsonjr! This looks great. Just a couple comments apart from the inline ones:
|
|
@nacx: How do I configure my local machine to run the live tests? I found some documentation that alludes to adding to the m2 settings, but I do not know what that means :-) That's why I did not write the live tests (yet). I was going to do another PR with that, but if you can help me with setting that up, so I can test it, I shall do it right away. |
The better options is to download your credentials as a JSON file. Once you have them, you can run all live tests as follows: Or if you want to run just one single test class: |
|
They take some time, so I'd recommend that you just run the class where you add the new tests :) |
|
@nacx: argh!! the notifications for your reply got lost in my inbox and I did not see them. sorry for the delay! i'll get to it asap. |
|
We are excited to use this feature. Awaiting for its release 👍 |
|
@utkarsh-devops This PR has been quiet for some time. Feel free to step in and help with the remaining bits! |
|
Superseded by #1106. |
No description provided.