This repository has been archived by the owner on Jul 25, 2020. It is now read-only.
More fixes to parallel download resource cleanup #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if ( destination.exists() ) | ||
| destination.delete(); | ||
| if ( !tempFile.renameTo(destination) ) { |
|
Does this also fix JCLOUDS-1176? (Just asking to understand the scope of this PR :)) |
|
@nacx 1176: I will try to do a separate PR for it (out of scope for this one). |
Great :) Thanks! |
gaul
approved these changes
Sep 14, 2016
zack-shoylev
force-pushed
the
parallel-resource-handling-fixes
branch
from
c18747d
to
2a30fb8
Compare
|
merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.