This repository has been archived by the owner on Jul 25, 2020. It is now read-only.
JCLOUDS-1368: Correct use of slicing algorithm #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
changed the title
|
I reworked this commit to correct the use of the slicing algorithm. JCLOUDS-1369 tracks improving the algorithm itself. |
gaul
force-pushed
the
gcs-large-upload
branch
2 times, most recently
from
7da53f5
to
94d519a
Compare
Previously this method only reported whether it created a container or not and callers could not determine whether there was an error or if the container already existed. References gaul/s3proxy#122.
MultipartUploadSlicingAlgorithm creates multiple equal-sized parts and a remaining amount. BaseBlobStore.putMultipartBlob used this interface incorrectly, which could create more parts than intended since the remaining size could be larger than the part size. This manifested with Google Cloud Storage which only allows 32 parts.
Previously with GCS and its maximum 32 parts, the slicing algorithm would sliced 3.2 GB blobs into (31) 32 MB parts and (1) 2.3 GB part. With this algorithm it creates (31) 100 MB parts and (1) smaller part.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultipartUploadSlicingAlgorithmcreates multiple equal-sized parts anda remaining amount.
BaseBlobStore.putMultipartBlobused thisinterface incorrectly, which could create more parts than intended
since the remaining size could be larger than the part size. This
manifested with Google Cloud Storage which only allows 32 parts.