This repository has been archived by the owner on Jul 25, 2020. It is now read-only.
JCLOUDS-1400: Honor signed URL content type #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacx
approved these changes
Apr 8, 2018
gaul
force-pushed
the
gcs/signed-url-content-type
branch
from
74a8672
to
d25d3b1
Compare
Done. |
gaul
changed the title
gaul
force-pushed
the
gcs/signed-url-content-type
branch
2 times, most recently
from
7cd40cc
to
8ec0e39
Compare
|
Upon reflection, I should change these tests to remove all the headers and rely only on URL parameters since this is how the features is intended to work. This will remove some of the header additions. |
|
LGTM, thanks! |
Also add GetOptions headers instead of replacing all headers.
gaul
force-pushed
the
gcs/signed-url-content-type
branch
from
8ec0e39
to
7e0a2db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.