This repository has been archived by the owner on Jul 25, 2020. It is now read-only.
Allows users to download large files efficiently and directly to disk. #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Planning to add streaming and more tests to this PR |
zack-shoylev
force-pushed
the
parallel-download-blob2
branch
from
405038a
to
1fbc551
Compare
|
@andrewgaul Do you have any notes on this? I would like to merge this before 2.0 so I can also work on getting similar functionality into base blobstore for the other providers. |
|
merged Will work on getting something very similar for the rest of the providers, might refactor it more then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this has come up in the past via emails, why not provide a way to efficiently get a local copy of the blob's contents? Users can already do it themselves, but it is somewhat complex, and comes up often. Here is a suggestion with swift, but should be doable with baseblobstore as well (if contentlength and ranges are supported).