-
Notifications
You must be signed in to change notification settings - Fork 218
base pr for - jclouds provider for google compute engine #1051
Conversation
All comments were addressed. please review! |
Addressed all reviewer comments and updated the downstream branches to reflect that (plus corrected potential similar issued). Live tests pass, gist: https://gist.github.com/4292017 @jclouds, @adriancole, @mattstep please review so that I can start pushing the other apis! Thanks |
jclouds-java-7-pull-requests #104 SUCCESS |
few things, but pretty much a go cleanup:
get rid of extra types:
make list stuff more coherent:
correct docs wrt PEM:
|
the only thing I left out is the readme stuff (although I did change the description of the credential to mention that it is a key a literal and not a file). The reason for this is that the readme will need an overall to add/mention the compute stuff anyway and I didn't want to loose the time doing a partial overall now. |
please sort out the defensive copy of collection, checkNotNull message strings, and make nullable fields thanks for shining it up! |
I think this should be the last set of changes. afaik everything is either optional or checked for null, every collection is defensibly copied. thank you for reviewing! as soon as this goes in i'll make the other pr's asap (with changes consistent with these reviews). compute is nearly done (mostly implemented but still missing some tests) so it should be a short path to get gce completely in. |
okie hopefully last sweep done :) thanks for keeping at it, david |
jclouds-java-7-pull-requests #126 SUCCESS |
if you can, try to finish up the last sweep of comments today, as very soon, master will diverge from 1.5.x branch, and this will be more difficult to cherry-pick. |
- addresses comments from jclouds#1010 - includes the following base apis - projects - operations - zones These are 3 small apis that are required by other apis in some place or another.
Adrian Cole » jclouds #729 SUCCESS |
jclouds-java-7-pull-requests #144 SUCCESS |
base pr for - jclouds provider for google compute engine
bam! |
These are 3 small apis that are required by other apis in some place or another.
removed the other apis from the core api
removed the page system test