-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot do instance check on autoray.numpy and ABC #20
Comments
Thanks for the issue, should be fixed by #21, will merge and mint a release shortly. |
jcmgray
added a commit
that referenced
this issue
May 10, 2024
fix NumpyMimic special attribute access (#20)
williamwen42
added a commit
to pytorch/pytorch
that referenced
this issue
May 14, 2024
Fixes #93624 but also requires jcmgray/autoray#20 to be fixed. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
williamwen42
added a commit
to pytorch/pytorch
that referenced
this issue
May 14, 2024
Fixes #93624 but also requires jcmgray/autoray#20 to be fixed. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this issue
May 15, 2024
ZelboK
pushed a commit
to ZelboK/pytorch
that referenced
this issue
May 19, 2024
Fixes pytorch#93624 but also requires jcmgray/autoray#20 to be fixed. Pull Request resolved: pytorch#125945 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125882, pytorch#125943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found when trying to fix pytorch/pytorch#93624.
Repro:
Error:
I got around this by adding
in the
NumpyMimic
class__getattribute__
. Perhaps additional cases need to be added as well?The text was updated successfully, but these errors were encountered: