-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for user-supplied cache kwarg #113
Check for user-supplied cache kwarg #113
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
- Coverage 79.19% 77.08% -2.12%
===========================================
Files 39 39
Lines 15377 15379 +2
===========================================
- Hits 12178 11855 -323
- Misses 3199 3524 +325
Continue to review full report at Codecov.
|
Unless I'm missing something, I'm not sure this patch will do anything, a function with the signature:
will never have I.e. In [1]: def foo(cache=True, **kwargs):
...: print(cache, kwargs)
...:
In [2]: foo(**{'cache': False})
False {} |
ah yes, you are right. I made a simple mistake when testing this. Sorry, you can close |
Fixes #112
simple fix to check for a user-supplied
cache
kwarg.Sorry that this is showing so many commits. I let my fork get way out of date with the main develop branch, so all these commits were just me trying to get things back in consistency so I could make the (very simple) PR.