krb5.conf parameter expansion #429
Conversation
Fixes jcmturner#428 Support parameter expansion for default_ccache_name, default_client_keytab_name and default_keytab_name. Additionally, parse krb5-config if it exists, for defaults that aren't set in krb5.conf. This should support MIT sites that use a self-maintained version or distros that change MIT defaults.
jcmturner
force-pushed
the
jake-scott/config-expand-vars
branch
from
3a5ccd1
to
995c1e9
Compare
| @@ -726,3 +731,100 @@ func (c *Config) JSON() (string, error) { | |||
| } | |||
| return string(b), nil | |||
| } | |||
|
|
|||
| var expandMap map[string]string | |||
There was a problem hiding this comment.
I have been trying to avoid global variables. Could this be a local variable to the LibDefaults.parseLines() method function?
|
|
||
| var expandMap map[string]string | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
I like to avoid using Go's init function as if there are issues with it during runtime it can be confusing to debug as it was not explicitly called by another function. Could we initiate the expandMap within the LibDefaults.parseLines() method?
| return | ||
| } | ||
|
|
||
| func ExpandParams(in string) (out string) { |
There was a problem hiding this comment.
I think we should make this a private function.
|
|
||
| if cfg == nil { | ||
| // find krb5-config | ||
| file, err := exec.LookPath("krb5-config") |
There was a problem hiding this comment.
Can you share some details on this file please? I've not been able to understand what this relates to. thanks
| } | ||
|
|
||
| var defaultPkgConfigVars = map[string]string{ | ||
| "prefix": "/usr", |
There was a problem hiding this comment.
These things are unix specific and gokrb5 is intended to be platform independent. I'm not sure I completely understand the purpose of needing things lie exec_prefix in a krb5.conf. I need to understand this more so we can figure out what would be an appropriate platform independent approach.
Fixes #428
Support parameter expansion for default_ccache_name, default_client_keytab_name and default_keytab_name.
Additionally, parse krb5-config if it exists, for defaults that aren't set in krb5.conf. This should support MIT sites that use a self-maintained version or distros that change MIT defaults.