Run all the shell/scripts files through shellcheck

scripts/up

@@ -15,7 +15,7 @@ while [ "$1" != "--" ]; do
 done
 
 shift
-run_command="$@ &"
+run_command="$*"
 last_hash=""
 up_pid=0
 
@@ -24,7 +24,7 @@ up-checksum() {
 }
 
 up-start-process() {
-  eval "$run_command"
+  eval "$run_command &"
   up_pid=$!
 }
 

shell/aliases

@@ -15,7 +15,7 @@ alias d=docker
 alias dc=docker-compose
 
 tm() {
-  tmux new -s "$(basename $PWD)"
+  tmux new -s "$(basename "$PWD")"
 }
 
 alias deflate="ruby -r zlib -e 'STDOUT.write Zlib::Deflate.deflate(STDIN.read)'"
@@ -28,7 +28,8 @@ hash pbcopy 2>/dev/null || {
 }
 
 if [[ -f /usr/libexec/java_home ]] ; then
-  export JAVA_HOME="$(/usr/libexec/java_home)"
+  JAVA_HOME="$(/usr/libexec/java_home)"
+  export JAVA_HOME
 fi
 
 alias curl-xhr="curl -H 'X-Requested-With: XMLHttpRequest'"

shell/homebrew

@@ -2,6 +2,7 @@
 
 hash brew 2>/dev/null && {
   if [[ -f "$(brew --prefix)/etc/bash_completion" ]] ; then
+    # shellcheck source=/dev/null
     . "$(brew --prefix)/etc/bash_completion"
   fi
 }
@@ -26,8 +27,8 @@ bru-leaves() {
 }
 
 bru-check-deps() {
-  while read pkg ; do
-    egrep -q "$@" -e "^(brew|cask) '$pkg'" || echo "$pkg"
+  while read -r pkg ; do
+    grep -Eq "$@" -e "^(brew|cask) '$pkg'" || echo "$pkg"
   done
 }
 

shell/node

@@ -5,14 +5,17 @@ alias ne='npm run-script'
 export NVM_DIR='/opt/nvm'
 NVM_SCRIPT='/usr/local/opt/nvm/nvm.sh'
 
-if [[ -f "$NVM_SCRIPT" ]]; then
+if [[ -f "$NVM_SCRIPT" ]] ; then
+  # shellcheck source=/dev/null
   . "$NVM_SCRIPT"
 fi
 
 nvm use default
 
 get-nvm-version() {
-  local version="$(echo "$NVM_BIN" | cut -d / -f 4)"
+  local version
+  version="$(echo "$NVM_BIN" | cut -d / -f 4)"
+
   if [[ "$version" == "versions" ]] ; then
     echo -n 'node-'
     echo "$NVM_BIN" | cut -d / -f 6
@@ -27,18 +30,16 @@ nvm-old-versions() {
       grep '^v' |
       sort |
       uniq |
-      while read v ; do
-        nvm ls "$v" | sed '$ d'
-      done
+      while read -r v ; do nvm ls "$v" | sed '$ d' ; done
 }
 
 npm-run() {
-  for task in $@; do
-    npm run $task
-    if [[ $? -ne 0 ]] ; then
+  for task in "$@" ; do
+    if ! npm run "$task" ; then
       exit 1
     fi
   done
 }
 
+# shellcheck source=/dev/null
 hash vault 2> /dev/null && . "$( vault --initpath )"

shell/prompt

@@ -7,15 +7,15 @@ get-git-branch() {
   echo "[$ref]"
 }
 
-RED='\e[0;31m'
-GREEN='\e[0;32m'
-YELLOW='\e[0;33m'
-BLUE='\e[1;34m'
-BLACK='\e[0;30m'
-WHITE='\e[0;37m'
-DEFAULT_COLOR='\e[0;39m'
+export COL_RED='\e[0;31m'
+export COL_GREEN='\e[0;32m'
+export COL_YELLOW='\e[0;33m'
+export COL_BLUE='\e[1;34m'
+export COL_BLACK='\e[0;30m'
+export COL_WHITE='\e[0;37m'
+export COL_DEFAULT='\e[0;39m'
 
-PS1="$RED(\$(get-nvm-version),\$(get-chruby-version)) $BLUE\w $YELLOW\$(get-git-branch) $DEFAULT_COLOR\n$ "
+PS1="$COL_RED(\$(get-nvm-version),\$(get-chruby-version)) $COL_BLUE\w $COL_YELLOW\$(get-git-branch) $COL_DEFAULT\n$ "
 
 # Make Vim et al use the full color palette
 if [[ "$COLORTERM" == 'gnome-terminal' ]] ; then

shell/ruby

@@ -7,9 +7,10 @@ alias gem-uninstall='gem list | cut -d " " -f 1 | xargs gem uninstall -Iax'
 CHRUBY_SCRIPT='/usr/local/share/chruby/chruby.sh'
 
 if [[ -f "$CHRUBY_SCRIPT" ]] ; then
+  # shellcheck source=/dev/null
   . "$CHRUBY_SCRIPT"
 fi
 
 get-chruby-version() {
-  chruby | grep '*' | cut -d ' ' -f 3
+  chruby | grep '\*' | cut -d ' ' -f 3
 }

shell/util

@@ -9,7 +9,7 @@ follow-redirect() {
 }
 
 remove-trailing-lines() {
-  sed -e :a -e '/^\n*$/{$d;N;}' -e '/\n$/ba' $1 > $1.sed-tmp
-  chmod --reference $1 $1.sed-tmp
-  mv $1.sed-tmp $1
+  sed -e :a -e '/^\n*$/{$d;N;}' -e '/\n$/ba' "$1" > "$1.sed-tmp"
+  chmod --reference "$1" "$1.sed-tmp"
+  mv "$1.sed-tmp" "$1"
 }