Fix missing parameter in Set#isProperSuperset [Josh W].

jcoglan · Jun 22, 2009 · 9a9c128 · 9a9c128
1 parent 547b845
commit 9a9c128
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/source/set.js b/source/set.js
@@ -128,7 +128,7 @@ JS.Set = new JS.Class('Set', {
     return this._members.length < other._members.length && this.isSubset(other);
   },
 
-  isProperSuperset: function() {
+  isProperSuperset: function(other) {
     return this._members.length > other._members.length && this.isSuperset(other);
   },
 

diff --git a/test/test.html b/test/test.html
@@ -961,6 +961,7 @@
 
             // http://en.wikipedia.org/wiki/Subset
             assert(new JS.HashSet([1,2]).isProperSubset(new JS.HashSet([1,2,3])));
+            assert(new JS.HashSet([1,3,2]).isProperSuperset(new JS.HashSet([1,2])));
             assert(new JS.HashSet([3,1,2]).isSubset(new JS.HashSet([1,2,3])));
             assert(!( new JS.HashSet([3,1,2]).isProperSubset(new JS.HashSet([1,2,3])) ));
             assert(new JS.SortedSet().isSubset(new JS.HashSet([1,2,3])));