Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Fix prod.js pointing to wrong build script #52

Closed
wants to merge 1 commit into from
Closed

Fix prod.js pointing to wrong build script #52

wants to merge 1 commit into from

Conversation

evelant
Copy link

@evelant evelant commented Sep 28, 2016

No description provided.

@jedwards1211
Copy link
Member

@fignuts prod.js is intended to point to build-meteor.js because it starts Webpack in watch mode for the client and server bundles after buildMeteor() and installMeteorDeps(). (It used to point to build.js before I made it use Webpack in watch mode.) Are you having any problems with the way it's working?

@evelant
Copy link
Author

evelant commented Sep 28, 2016

@jedwards1211 Yes, try to run it as is and you will get an error about missing 'index.js' in the build dir. Index.js is compiled to the build dir by by buildServer which is not called in this case.

@jedwards1211
Copy link
Member

Oh I see, yes, the integration tests aren't catching that. The best solution will just be to compile index.js to the build dir instead of running the entire build.js. I'll make the change tomorrow. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants