chore: reduce API surface #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2022
jcornaz
added a commit
that referenced
this pull request
Jan 19, 2022
chore!: All struct fields are now private chore!: All enums are marked with `#[non_exhaustive]` chore!: The constructor of `AnimationPlugin` is now private. Use `AnimationPlugin::default()` instead. Release-As: 2.0.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #25, where we discovered the difficutly of changing implementation details without breaking the API.
Since I am now preparing a breaking release, I'd like to use that opportunity to reduce the api surface as much as possible, so that we reduce the likelyhood of having the same problems we had with #25.