feat!: Update animation during the CoreStage::Update stage
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like it's not possible to detect component removal during the
CoreState::Laststage. Probably because that's when the state are reset.So updating the animation during the post update makes harder for users to detect when an animation has ended. And it didn't make a lot of sense in the first place anyway.
This PR changes the animation update to run during the
CoreStage::Updatestage. So that it is easy to detect the end of an animation during theCoreStage::PostUpdate.It includes and an example written by @johnteske that I simplified a bit.