fix greetings with callback #855

jcubic · Feb 1, 2023 · 77f703b · 77f703b
1 parent 29791ab
commit 77f703b
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/js/jquery.terminal-src.js b/js/jquery.terminal-src.js
@@ -8345,11 +8345,18 @@
                     self.echo(settings.greetings);
                 } else if (type === 'function') {
                     self.echo(function() {
-                        try {
-                            return settings.greetings.call(self, self.echo);
-                        } catch (e) {
-                            settings.greetings = null;
-                            display_exception(e, 'greetings');
+                        if (settings.greetings) {
+                            try {
+                                var defer = new $.Deferred();
+                                var ret = settings.greetings.call(self, defer.resolve);
+                                if (ret) {
+                                    defer.resolve(ret);
+                                }
+                                return defer.promise();
+                            } catch (e) {
+                                settings.greetings = null;
+                                display_exception(e, 'greetings');
+                            }
                         }
                     });
                 } else {