Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALT+D issues #485

Closed
jcubic opened this issue Apr 15, 2019 · 1 comment
Closed

ALT+D issues #485

jcubic opened this issue Apr 15, 2019 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 15, 2019

Expected behavior

It never jump to address bar and don't move keys

Actual behavior

It sometimes jump to address bar and after deleting work and pressing key it insert at wrong place. Probably position is wrong after delete.

Steps to reproduce

  1. jumps to address bar
  • not sure interacting with terminal for a while and pressing ALT+D few times it sometimes jump to address bar.
  1. insert issue
  • move cursor at the end of the sentence
  • move cursor using CTRL+ARROWLEFT few words to left
  • press ALT+D to delete work
  • type something
@jcubic jcubic added the Bug label Apr 15, 2019
jcubic added a commit that referenced this issue Apr 16, 2019
@jcubic
Copy link
Owner Author

jcubic commented Apr 16, 2019

The problem was that hold indicator was not reset when you press different keys so if you hit keydown fast few times it trigger hold key that didn't have keymap (no HOLD+ALT+D) there was not preventDefault call.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 16, 2019
@jcubic jcubic closed this as completed Apr 18, 2019
@jcubic jcubic mentioned this issue Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant