Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL+U issue #488

Closed
jcubic opened this issue Apr 22, 2019 · 1 comment
Closed

CTRL+U issue #488

jcubic opened this issue Apr 22, 2019 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 22, 2019

Expected behavior

CTRL+U should clear command before cursor

Actual behavior

It sometimes show source code (default behavior)

Steps to reproduce

Play with terminal for a while press CTRL+U few times

Notes

this works:

$(document).keydown(function(e) {
    if (e.key.toLowerCase() === 'u' && e.ctrlKey) {
        return false;
    }
});

so the problem is in terminal code, this may be related to #485

@jcubic jcubic added the Bug label Apr 22, 2019
jcubic added a commit that referenced this issue May 5, 2019
@jcubic
Copy link
Owner Author

jcubic commented May 5, 2019

The problem was that after hold any key and change key the hold flag was not cleared. So next key was also marked as hold.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 5, 2019
@jcubic jcubic closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant