Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pick where formatting should be used #588

Closed
3 tasks done
jcubic opened this issue Jun 14, 2020 · 3 comments
Closed
3 tasks done

Allow to pick where formatting should be used #588

jcubic opened this issue Jun 14, 2020 · 3 comments
Labels
documentation feature in progress resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 14, 2020 •
edited
Loading

I have idea for a new feature for jQuery Terminal

If you double tab in LIPS demo
https://codepen.io/jcubic/pen/GxgWBq

THe big chunk of text is marked as one big regular expression because there is no way to turn formatters off. It would be nice if you can disable that formatting with option.

  • add feature
  • more unit tests for the future
  • write documentation
@jcubic jcubic added the feature label Jun 14, 2020
@jcubic jcubic changed the title Allow to disable formatting in double tab completion Allow to pick where formatting should be used Jul 22, 2020
@jcubic
Copy link
Owner Author

jcubic commented Jul 22, 2020 •
edited
Loading

There is also need to toggle formatters in different places:

  • prompt
  • cmd
  • echo
  • completion (never apply formatters)

jcubic added a commit that referenced this issue Jul 23, 2020
@jcubic
new API for apply_formatters #588
5485e3f 
Pick where to apply formatters in function formatters
Prism to apply formatters by default only in echo and command
jcubic added a commit that referenced this issue Jul 23, 2020
@jcubic
Add toggle formatters options for regex formatters #588
e01d79d
@jcubic
Copy link
Owner Author

jcubic commented Jul 23, 2020

Completion don't have formatting from long time, the issue with Demo was that it call echo in doubleTab option.

The new API now allow to add send options for function formatters and function can decide if she want to format the string. Regex formatters also have options to turn on formatting as 3rd argument.

Options are: echo, prompt and command if it's true then regex formatter will be processed and in function the options will have any of this field set to true when this context is executed.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 23, 2020
jcubic added a commit that referenced this issue Jul 23, 2020
@jcubic
fix loop in regex formatter #588
09d43d2 
If no options were used loop options didn't work, so now terminal check
if there are no formatter options if so it always apply formatters
@jcubic jcubic removed the resolved if issue is resolved, it will be open until merge with master label Jul 23, 2020
jcubic added a commit that referenced this issue Aug 1, 2020
@jcubic
unit tests for toggle formatters #588
3ad462d
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Aug 1, 2020
@jcubic jcubic mentioned this issue Apr 19, 2021
Open
18 tasks
@jcubic
Copy link
Owner Author

jcubic commented Jul 8, 2021

Docs added to Wiki https://github.com/jcubic/jquery.terminal/wiki/Formatting-and-Syntax-Highlighting

@jcubic jcubic closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation feature in progress resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic