Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easy to have border + border-radius on terminal without browser bugs #766

Closed
jcubic opened this issue Mar 22, 2022 · 0 comments
Closed

Make it easy to have border + border-radius on terminal without browser bugs #766

jcubic opened this issue Mar 22, 2022 · 0 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master
Milestone
2.33.0

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 22, 2022

I have an idea for a new feature for jQuery Terminal

Here is the problem:

term_02

Firefox 99 that fixed the issue with horizontal scrollbar. Missing rounded corners.

term_01

Google Chrome. When the scrollbar is present missing part of the border in the corners.

Here is the fix:

https://codepen.io/jcubic/pen/wvpzZQM?editors=0110

It would be nice to add terminal-container that has a scrollbar so you can use border-radius on .terminal. There also can be overflow: hidden so you only need border-radius: and border.
@jcubic jcubic added the feature label Mar 22, 2022
@jcubic jcubic modified the milestones: 2.24.0, 2.33.0 Mar 26, 2022
jcubic added a commit that referenced this issue Mar 27, 2022
@jcubic
add scroller element #766
bda529d 
This will allow to easily add border + border-radius on terminal
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Mar 27, 2022
@jcubic jcubic closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.33.0
Development

No branches or pull requests
1 participant
@jcubic