Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise from echo typing animation is not resolved #797

Closed
jcubic opened this issue Jun 14, 2022 · 0 comments
Closed

Promise from echo typing animation is not resolved #797

jcubic opened this issue Jun 14, 2022 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 14, 2022

Issue summary

When you echo Promise and after echo typing animation that second echo promise is not resolved

Expected behavior

I expect the promise to be resolved

Actual behavior

The promise is not resolved

Steps to reproduce

  1. Open https://codepen.io/jcubic/pen/mdXvMzR?editors=0010
  2. it should print "DONE"

Additional notes

The problem is with delayed commands (echo_delay array) when echo is waiting, it pushes the typing animation command to the delay array, but the original promise (deferred) is lost and is never resolved. Typing animation is resolving the wrong promise.

@jcubic jcubic added the Bug label Jun 14, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jun 14, 2022
@jcubic jcubic closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant