Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to type/enter input on mobile devices #846

Closed
alexkrys123 opened this issue Dec 14, 2022 · 10 comments
Closed

It's impossible to type/enter input on mobile devices #846

alexkrys123 opened this issue Dec 14, 2022 · 10 comments
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master

Comments

@alexkrys123
Copy link

Issue summary

It's impossible to type/enter input on mobile devices - no keyboard appears to type input

Expected behavior

Keyboard should appear to type on it

Actual behavior

Nothing appears to type

Steps to reproduce

Try on https://terminal.jcubic.pl/ or https://terminal.jcubic.pl/prism.html - none of the sites provide an option to input the text

Browser and OS

Chrome, Opera on Android

Additional notes

@jcubic
Copy link
Owner

jcubic commented Dec 14, 2022

Thanks for the report, it seems that the latest version broke mobile support. The keyboard doesn't work. If you need this ASAP you can use version 2.34.0 You can test it here:

https://jcubic.github.io/jquery.terminal/?ver=2.34.0

@redthing1
Copy link

I tried that previously version on Android and it does not work either. I have a Google Pixel XL on Android 11.

@redthing1
Copy link

It works in mobile chrome but not Firefox.

@jcubic
Copy link
Owner

jcubic commented Dec 19, 2022

Will check. It may take a while to fix.

@redthing1
Copy link

Thanks. Really appreciate, ping me whenever you get to it.

@adamclement-exe
Copy link

tested my site on android chrome with v2.34 today and is working http://adamsbashgame.pythonanywhere.com/

not with latest version though

@alexkrys123
Copy link
Author

Chrome works with 2.34, Firefox not

jcubic added a commit that referenced this issue Dec 23, 2022
@jcubic
Copy link
Owner

jcubic commented Dec 23, 2022

Firefox is fixed on the devel branch, I've added something that was supposed to work but I didn't actually test how it would work on Firefox. And there are automated tests like this.

I still need to figure out what change in version 2.35 make mobile Chrome fail to open the virtual keyboard.

@jcubic
Copy link
Owner

jcubic commented Dec 24, 2022

I've found that the problem was:

.terminal, .terminal *, .cmd, .cmd *, .cmd textarea {
    all: revert;
}

CSS added in 2.35, this is a bug in Chrome that I've reported to the Chromium project:

CSS rule * { all: revert; } breaks contenteditable on mobile.

jcubic added a commit that referenced this issue Dec 24, 2022
@jcubic
Copy link
Owner

jcubic commented Dec 24, 2022

The fix was released in version 2.35.1.

@jcubic jcubic closed this as completed Dec 24, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

4 participants