Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term::geometry() height is off by 10px #873

Closed
jcubic opened this issue Apr 10, 2023 · 0 comments
Closed

term::geometry() height is off by 10px #873

jcubic opened this issue Apr 10, 2023 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone
2.36.0

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 10, 2023

Issue summary

When calling term::geometry() the height of the terminal is too big for 10px by default.

Steps to reproduce

  1. Open Match Terminal into 3D image of the laptop Demo
  2. Resize (using the points) so the edges of the terminal are visible
  3. there is 10px space between the points and the terminal

Additional notes

This is because the geometry() is wrong. If you disable matching (comment out --transform: CSS variable in JavaScript) the size will show 250px not 240px maybe because it multiple padding by two, but there is no bottom padding.
@jcubic jcubic added the Bug label Apr 10, 2023
@jcubic jcubic added this to the 2.36.0 milestone Apr 10, 2023
jcubic added a commit that referenced this issue Apr 10, 2023
@jcubic
fix geometry #873 + refactor variable name
47639fc
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 10, 2023
@jcubic jcubic closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.36.0
Development

No branches or pull requests
1 participant
@jcubic