Change the Twitter API call to follow a UserId set #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice 👍 |
garretcarrot
force-pushed
the
follow-users
branch
from
45c5739
to
da5d8fe
Compare
|
Sorry about the delay. This is merged and will be in the next release. |
jcustenborder
added a commit
that referenced
this pull request
Aug 14, 2019
* Change the Twitter API call to follow a UserId set (#19) * Change the Twitter API call to follow a UserId set * Default to empty set when userIds unspecified * README: note filter.userIds in configuration list * Fix userIds default value * Correct logic to determine the number of tasks to use. Added unit test to ensure logic is valid. Fixes #15. * Moved to use SourceRecordDeque for temporary record storage. This will ensure that the task will properly exit. Fixes #20. * Updated parent pom to the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background information
For the use case of tracking a user's tweets/replies/mentions, the
filter.keywordsproperty can be exploited to scan for tweets containing the user's Twitter handle. This is supported by the "track" request paramater of the API endpoint, and can sometimes perform acceptably for mentions and replies.But to select for a user's tweets themselves, only in the rare case that a user's tweet contains their own username will it be captured—since the matching keywords must appear somewhere in the tweet body. Otherwise, the connector currently has no way of tracking tweets originating from a given account.
However, the API also provides us with a
followrequest parameter (see the doc referred to above), which can bring to bear the desired tweets.Implementation summary
FilterQueryvia itsfollowmethodBefore & after
After this change, the
filter.userIdsproperty, a comma-separated list of UserId values will be allowed (which could be an empty string, which is the default), and if specified will allow the connector to follow tweets originating from, replying to, or mentioning the listed users.In addition, the connector will continue to track all other tweets that contain any specified filter keywords in their text.