-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textarea): Added autosize with vueUse useTextareaAutosize #37
Conversation
Hi, Thanks for the PR. This is really useful ❤️ I reviewed it in time I get and found that the initial value of const { textarea, input } = useTextareaAutosize({
input: props.modelValue,
}) However, the main problem is we don't have just textarea. Our border styles are from its parent wrapper and I tried updating your PR but I think we need a few changes in VueUse that allows us to pass two separate elements just like we have. Styling element (out input wrapper) & actual textarea our textarea in To access the input wrapper from Hence, there's some work we need to do on VueUse side if they approve and later on we need to update this PR. I will create new PR/issue tomorrow on VueUse regarding this. Thanks :) |
I didn't see that! |
I added the ability to limit height. Also, I found an issue with Furthermore, mixing pixel value and class value for |
This reverts commit 59603c6.
Hi, can this now be merged since the referenced issue in vueuse has been resolved. |
Yes, I noticed that and added it to the project board 😇 Just give me some time to update the project board. |
Hi @ManUtopiK Thanks so much for your efforts. We now have SFC instead of TSX so have to do it in a separate commit. Thanks for your contribution 🙏🏻 |
No description provided.