-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use color and variant for AListItem #87
Conversation
❌ Deploy Preview for anu-vue failed.
|
Is this change acceptable ? I write the doc ? |
I will review it soon |
toRef(props, 'states'), | ||
{ statesClass: 'states:10' }, | ||
computed(() => ({ statesClass: props.isActive ? 'states:10' : 'hover:states:10' })), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManUtopiK What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean what's the need for hover:states:10'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember exactly why it was for. But I struggled a little bit with states before #86.
Also, there are still some improvements to do.
- We lose the state of the
isActive
item when using together acolor
AND the varianttext
.
Basic example without color and text:
With props color="success" variant="text"
:
Donut jujubes
isn't highlighted.
- We can't add color when there is no click handler.
<AListItem
title="Send"
color="success"
/>
color
props do nothing here.
…i#86) Co-authored-by: JD Solanki <jdsolanki0001@gmail.com>
if we use variant group user have to configure it
…ListItemLayerProps
Arff, I'm really sorry for the big mess I made on this branch. I wanted to update and use #86 but I made a mistake. It's late. I will close this pull request and create a new one tomorrow... |
I close this pull request for now. I broke the branch anyway. |
Hi @ManUtopiK I am refactoring the whole codebase from TSX to SFC so if want to create a new PR, please wait for 1 or 2 days to get latest updates. |
Woah, a lot of changes ! I've worked on a loading component. I didn't finish. I'm back after Christmas. |
We are just moving from TSX to SFC, Transition will be easier. We just have to convert the code. Your implementation logic will stay the same. Here are the benefits I found so far ❤️ One of the most important is #15 I will finish refactoring in maybe 1-2 days. Merry Christmas, Buddy 🥳 |
Hi @ManUtopiK refactoring PR is merged! 😇 |
This change add the possibility to use layerProps (color and variant) to
AListItem
with default totext
.If
color
is provided withvariant
,is-active
item use this variant and hovered item uselight
variant.TODO :