shorten etcd wait_for_line (~3.4 compatibility) #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyHat
force-pushed
the
patch-1
branch
4 times, most recently
from
1eb3b03
to
58f8ddf
Compare
jd
previously approved these changes
Nov 6, 2019
jd
previously approved these changes
Nov 6, 2019
|
Not sure why this is failing now. but then we just hang until travis kills us |
|
Any chance it will be merged soon? |
|
CI was not passing so not sure it was working. Can anyone look into it? |
|
UPDATE: It still hangs here after the change, and I don't know why :( |
Starting at ~3.4 the output is now `embed: serving insecure client requests on 127.0.0.1:2379, this is strongly discouraged!` so `client requests on` still matches both
|
This should have been addressed in #135, please have a try :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting at ~3.4 the output is now
embed: serving insecure client requests on 127.0.0.1:2379, this is strongly discouraged!so
client requests onstill matches both